bpo-15786: IDLE: Fix behavior when mouse click at autocompletetion window #1811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndow This fix behavior on Windows, MacOS and Linux platform. The root problem is cause by non-check for hide_event. When user click at acw, root widget will get focusOut event, then trigger hide_window to close the acw. It should only be hide when acw is active, and acw didn't get focus at FocusOut event (this event bind on acw and widget), or when widget get a ButtonPress event (this event only bind on widget). MacOS will freeze after double click on acw, this because when doubleclick_event try to hide window at the end, hide_window function destory whole acw, but tkinter didn't get focus back to widget. So it should set focus on widget first, then destory acw. Windows can not response on double click event, because the misbehavior of Configure event, when acw is showed, tkinter will call winconfig event multiplue time, that cause tkinter can not response to double click event. When on Windows, it will unbind Configure event whe first time get into winconfig_event to prevent multiple call of this event.
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Yhg1s, @kbkaiser and @terryjreedy to be potential reviewers. |
Contributor
Author
|
@terryjreedy, would you like to take a look about the fixed? If this work, I think we can backported to 3.6 and fixed in the 3.6.2 released |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 14, 2017
…1811) The root problem was non-check for hide_event. When user clicks on autocomplete window (acw), root widget gets focusOut event, then triggers hide_window to close the acw. It should only be hide when acw is active, and acw didn't get focus at FocusOut event (this event bind on acw and widget), or when widget get a ButtonPress event (this event only bind on widget). MacOS froze after double click on acw because when doubleclick_event try to hide window at the end, hide_window function destory whole acw, but tkinter didn't get focus back to widget. So set focus on widget first, then destory acw. Windows could not respond on double click event, because of the misbehavior of Configure event. When acw was shown, tkinter called winconfig event multiple times. That caused tkinter to not response to double click event. When on Windows, unbind Configure event first time get into winconfig_event to prevent multiple call of this event. (cherry picked from commit 778b484)
terryjreedy
added a commit
that referenced
this pull request
Jun 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix behavior on Windows, MacOS and Linux platform.
The root problem is caused by non-check for hide_event. When user click
at acw, root widget will get focusOut event, then trigger hide_window to
close the acw. It should only be hide when acw is active, and acw didn't
get focus at FocusOut event (this event bind on acw and widget), or when
widget get a ButtonPress event (this event only bind on the widget).
MacOS will freeze after double click on acw, this because when
doubleclick_event try to hide window at the end, hide_window function
destroy the whole acw, but tkinter didn't get focus back to widget. So it
should set focus on widget first, then destroy acw.
Windows can not response to double click event because the misbehavior
of Configure event, when acw is showed, tkinter will call winconfig
event multiple time, that cause tkinter can not response to double
click event. When on Windows, it will unbind Configure event when first
time get into winconfig_event to prevent multiple calls of this event.
Previous PR: #1517