Skip to content

[3.6] bpo-39421: Fix posible crash in heapq with custom comparison operators (GH-18118) #18146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ned-deily merged 1 commit into from
Jan 23, 2020
Merged

[3.6] bpo-39421: Fix posible crash in heapq with custom comparison operators (GH-18118) #18146

ned-deily merged 1 commit into from
Jan 23, 2020

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 23, 2020 •
edited by pablogsal
Loading

  • bpo-39421: Fix posible crash in heapq with custom comparison operators

Co-authored-by: Pablo Galindo [email protected]

https://bugs.python.org/issue39421

Automerge-Triggered-By: @pablogsal

@pablogsal @miss-islington
bpo-39421: Fix posible crash in heapq with custom comparison operators (
509a1d8 
pythonGH-18118)

* bpo-39421: Fix posible crash in heapq with custom comparison operators

* fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators

* fixup! fixup! bpo-39421: Fix posible crash in heapq with custom comparison operators
(cherry picked from commit 79f89e6)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2020
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 23, 2020

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@pablogsal pablogsal requested a review from ned-deily January 23, 2020 14:39
@ned-deily ned-deily merged commit c563f40 into python:3.6 Jan 23, 2020
@miss-islington miss-islington deleted the backport-79f89e6-3.6 branch January 23, 2020 14:49
@Dk0n9 Dk0n9 mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @pablogsal @ned-deily @the-knights-who-say-ni @bedevere-bot