Get mock coverage back to 100% #18228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to ever be exectuted.
The assertion makes sure this continues to be the case!
Before this change, the stop-without-start blows up with `TypeError: 'NoneType' object is not iterable`
Contributor
Author
|
Now that https://bugs.python.org/issue39485 is resolved, this PR is the last blocker for the 4.0 release of the backport. Since there have been no complaints, I'm going to go ahead and merge it. |
|
Contributor
Author
|
It's not clear to me what's actually failed in the buildbot above? Anyone able to enlighten me? |
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
* use the `: pass` and `: yield` patterns for code that isn't expected to ever be executed. * The _Call items passed to _AnyComparer are only ever of length two, so assert instead of if/else * fix typo * Fix bug, where stop-without-start patching dict blows up with `TypeError: 'NoneType' object is not iterable`, highlighted by lack of coverage of an except branch. * The fix for bpo-37972 means _Call.count and _Call.index are no longer needed. * add coverage for calling next() on a mock_open with readline.return_value set. * __aiter__ is defined on the Mock so the one on _AsyncIterator is never called.
Contributor
|
@cjw296 From what I can tell, it looks like it occurred from (which resulted in Perhaps there's some form of intermittent failure present there, but it will likely require further investigation. Is this worth opening a bpo issue for, @vstinner? |
Contributor
Author
|
Yeah, I'm fairly sure I had this test fail when I merged to master a while back: |
Member
|
I suggest to comment https://bugs.python.org/issue39088. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wish there was a way to enforce coverage on mock in cpython, it's so easy to slip and always introduces dead code, at best, and bugs at worst.
I'm neutral on whether or not this should be backported to 3.8 or 3.7, however I would like to land this soon as possible so we can get mock 4.0 out and get a lot more feedback on all the AsyncMock stuff :-)