Skip to content

Conversation

@idomic
Copy link
Contributor

@idomic idomic commented Feb 2, 2020

@idomic
Copy link
Contributor Author

idomic commented Feb 2, 2020

@asvetlov Do I need news here? it's only documentation.
Would you also like to include a paragraph on the algorithm after the changeset, Changed in version 3.5: Added support for SSL/TLS in ProactorEventLoop. ?

@JulienPalard JulienPalard changed the title 39128 - Added happy_eyeballs_delay, interleave to function signature bpo-39128: Added happy_eyeballs_delay, interleave to function signature Feb 6, 2020
@JulienPalard
Copy link
Member

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

@idomic
Copy link
Contributor Author

idomic commented Feb 8, 2020

.. versionchanged:: 3.8
Added the happy_eyeballs_delay and interleave parameters.

I agree

Do I need news here?

Not needed, it's only documentation.

What about adding a:

.. versionchanged:: 3.8
   Added the *happy_eyeballs_delay* and *interleave* parameters.

Done.

@JulienPalard JulienPalard merged commit 5305cc9 into python:master Feb 10, 2020
@miss-islington
Copy link
Contributor

Thanks @idomic for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18428 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 10, 2020
miss-islington added a commit that referenced this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants