bpo-38894: Fix pathlib.Path.glob in the presence of symlinks and insufficient permissions #18815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
bpo-38894
branch
5 times, most recently
from
28c8710 to
ad03688
Compare
…fficient permissions Co-authored-by: Matt Wozniski <[email protected]>
pitrou
reviewed
Mar 6, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thanks for tackling this hairy issue!
| yield p | ||
| if self.dironly: | ||
| try: | ||
| if not entry.is_dir(): |
Member
There was a problem hiding this comment.
Perhaps add a comment mentioning that it can raise a PermissionError which is not part of the ignored errnos?
…nd insufficient permissions
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2020
…fficient permissions (pythonGH-18815) Co-authored-by: Matt Wozniski <[email protected]> (cherry picked from commit eb7560a) Co-authored-by: Pablo Galindo <[email protected]>
|
GH-18830 is a backport of this pull request to the 3.8 branch. |
|
GH-18831 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 7, 2020
…fficient permissions (pythonGH-18815) Co-authored-by: Matt Wozniski <[email protected]> (cherry picked from commit eb7560a) Co-authored-by: Pablo Galindo <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 7, 2020
…fficient permissions (GH-18815) Co-authored-by: Matt Wozniski <[email protected]> (cherry picked from commit eb7560a) Co-authored-by: Pablo Galindo <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 7, 2020
…fficient permissions (GH-18815) Co-authored-by: Matt Wozniski <[email protected]> (cherry picked from commit eb7560a) Co-authored-by: Pablo Galindo <[email protected]>
blueyed
added a commit
to blueyed/cpython
that referenced
this pull request
Oct 29, 2020
Refs: - bpo-24120 (python@6c2d33a258bb) uses to broad try/catch for PermissionError, which led to bpo-38894 in the first place - bpo-38894 (python#18815) fixed handling only for `_WildcardSelector` TODO: tests for others?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38894
I have opted to reproduce the behaviour of Python < 3.7 instead of ignoring
EACCESSto avoid calling needlesslyentry.is_dir()whenself.dironlyisFalse.