bpo-30532: email.policy.SMTP.fold() mangles long headers #1892
Conversation
|
@jhillacre, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bitdancer, @serhiy-storchaka and @ezio-melotti to be potential reviewers. |
Lib/email/_header_value_parser.py
Outdated
There was a problem hiding this comment.
Looks good to me! You could remove the repeated comment from line 340 while you are here.
|
@zvyn OK, got it in 3d07dc5. |
|
Rebased from master so the windows build passes and gives the PR the ✔️. |
|
Is there anything I need to do to keep the PR moving? |
bitdancer
left a comment
bitdancer
left a comment
There was a problem hiding this comment.
One small change, and we need a NEWS entry (which should now use the 'blurb' mechanism, see the recent updates to the devguide).
Lib/email/_header_value_parser.py
Outdated
| # Peel off the leading whitespace and make it sticky, to | ||
| # avoid infinite recursion. | ||
| folded.stickyspace = str(part.pop(0)) | ||
| folded.stickyspace = ws |
There was a problem hiding this comment.
It looks like this was a case of me "fixing" the code, and missing one spot (for which there obviously wasn't a test). To make this code match other other instances of this logic, you should put an str call around ws.
|
@bitdancer, Added your requested changes in ec63c3c and 29f92f0. Should I be rebasing this pull request to a single commit with the message of |
|
Nope, it gets squashed during merge. Now it needs backport to 3.6, and I think 3.5 is still open for backports. You can do that (see devguide), or someone else will, since it isn't (yet) automated. |
7 participants
Pull request for http://bugs.python.org/issue30532