Add missing sys import to socket_helper.py #19791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
There was a missing import that could cause: Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/support/socket_helper.py", line 242, in transient_internet
yield
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/test_nntplib.py", line 320, in setUpClass
cls.server = cls.NNTP_CLASS(cls.NNTP_HOST,
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line 1043, in __init__
super().__init__(host, port, user, password, readermode,
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line 1010, in __init__
super().__init__(file, host, readermode, timeout)
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line 330, in __init__
self.welcome = self._getresp()
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/nntplib.py", line 455, in _getresp
raise NNTPTemporaryError(resp)
nntplib.NNTPTemporaryError: 400 Permission denied: Too many unknown commands sent to the server
Traceback (most recent call last):
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/test_nntplib.py", line 330, in setUpClass
raise unittest.SkipTest(f"{cls} got EOF error on connecting "
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/contextlib.py", line 135, in __exit__
self.gen.throw(type, value, traceback)
File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-ppc64le.clang-installed/build/target/lib/python3.9/test/support/socket_helper.py", line 245, in transient_internet
sys.stderr.write(denied.args[0] + "\n")
NameError: name 'sys' is not defined |
Member
Author
|
I am merging this as is causing a lot of buildbot failures and is a trivial fix. |
Member
|
Thank you Pablo. |
Member
|
I ran pyflakes to check imports and created https://bugs.python.org/issue40443 as a follow-up :-) |
Member
Oh, it was worth it, I found another bug ;-) #19825 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.