Skip to content

bpo-40275: Adding a threading_helper in test.support #20263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 8 commits into from
May 27, 2020
Merged

bpo-40275: Adding a threading_helper in test.support #20263

vstinner merged 8 commits into from
May 27, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 20, 2020 •
edited by bedevere-bot
Loading

vstinner
vstinner reviewed May 20, 2020
View reviewed changes
vstinner
vstinner approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would prefer to get @serhiy-storchaka review on this PR since it changes many tests.

@shihai1991
Copy link
Member Author

shihai1991 commented May 20, 2020

LGTM, but I would prefer to get @serhiy-storchaka review on this PR since it changes many tests.

Sure, my eyes can't see clealy after changed those tests ; )

@brettcannon brettcannon removed their request for review May 20, 2020 22:59
@berkerpeksag berkerpeksag removed their request for review May 21, 2020 12:30
@terryjreedy terryjreedy mentioned this pull request May 27, 2020
Closed
@vstinner
Copy link
Member

vstinner commented May 27, 2020

Hum, sadly threading is still imported indirectly by subprocess and platform, and so this PR is not enough. But I merge the PR anyway to ease @shihai1991 work, since it's a huge PR and so it's hard to maintain. Overall, it enhances test.support anyway ;-) I will work on following changes to import platform and subprocess lazily.

@vstinner vstinner merged commit e80697d into python:master May 27, 2020
pquentin added a commit to pquentin/trio-asyncio that referenced this pull request Jun 17, 2020
@pquentin
Fix testsuite on Python 3.10
6b77d9b 
python/cpython#20263
pquentin added a commit to pquentin/trio-asyncio that referenced this pull request Jun 17, 2020
@pquentin
Fix testsuite on Python 3.10
4df182e 
python/cpython#20263
@gpshead
Copy link
Member

gpshead commented Aug 7, 2022

A question relevant to the test.support APIs this PR introduced: https://discuss.python.org/t/test-harness-for-leakage-detection-does-threading-setup-duplicates-saved-test-environment/17097

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 7, 2022

This PR did not introduce any new API. It is a pure refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@rhettinger rhettinger Awaiting requested review from rhettinger

@tiran tiran Awaiting requested review from tiran

@vsajip vsajip Awaiting requested review from vsajip

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shihai1991 @vstinner @gpshead @serhiy-storchaka @corona10 @the-knights-who-say-ni @bedevere-bot