bpo-28556: Updates to typing module #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zware, @serhiy-storchaka and @rhettinger to be potential reviewers. |
Member
|
Take it away, Mariatta the orchestra leader! |
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Jun 10, 2017
This PR contains two updates to typing module: - Support ContextManager on all versions (original PR by Jelle Zijlstra). - Add generic AsyncContextManager.. (cherry picked from commit 29fda8d)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Jun 10, 2017
This PR contains two updates to typing module: - Support ContextManager on all versions (original PR by Jelle Zijlstra). - Add generic AsyncContextManager.. (cherry picked from commit 29fda8d)
Member
Member
Author
|
Thank you Mariatta! |
Mariatta
added a commit
that referenced
this pull request
Jun 10, 2017
Mariatta
added a commit
that referenced
this pull request
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two updates to
typingmodule:ContextManageron all versions (original PR by Jelle Zijlstra).AsyncContextManager.This needs to be backported to 3.5 and 3.6 (preferably before Monday).
Attn: @gvanrossum