Skip to content

bpo-40275: Add os_helper submodule in test.support #20765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Jun 10, 2020
Merged

bpo-40275: Add os_helper submodule in test.support #20765

vstinner merged 3 commits into from
Jun 10, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jun 9, 2020 •
edited
Loading

remove the following vars, functions, classes in os_helper:

  • rmtree()
  • unlink()
  • rmdir()
  • FS_NONASCII
  • TESTFN_UNICODE, TESTFN_NONASCII, TESTFN_UNENCODABLE, TESTFN_UNDECODABLE
  • SAVEDCWD
  • temp_dir()
  • change_cwd()
  • temp_cwd()
  • temp_umask()
  • create_empty_file()
  • make_bad_fd()
  • EnvironmentVarGuard
  • can_symlink(), skip_unless_symlink()
  • can_xattr(), skip_unless_xattr()
  • fs_is_case_insensitive()
  • fd_count()
  • FakePath

https://bugs.python.org/issue40275

vstinner
vstinner reviewed Jun 9, 2020
View reviewed changes
@vstinner vstinner mentioned this pull request Jun 9, 2020
Closed
@shihai1991 shihai1991 changed the title bpo-40275: Add os_helper submodule in test.support [another idea] bpo-40275: Add os_helper submodule in test.support Jun 10, 2020
vstinner
vstinner reviewed Jun 10, 2020
View reviewed changes
@vstinner vstinner merged commit 0d00b2a into python:master Jun 10, 2020
@vstinner
Copy link
Member

vstinner commented Jun 10, 2020

Thanks @shihai1991, merged. Would you be interested to create import_helper submodule now? https://bugs.python.org/issue40275#msg368840

@shihai1991
Copy link
Member Author

shihai1991 commented Jun 10, 2020

Thanks @shihai1991, merged. Would you be interested to create import_helper submodule now? https://bugs.python.org/issue40275#msg368840

Thanks, victor. I will continue create PRs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot