Skip to content

bpo-40275: Use new test.support helper submodules in tests #21219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jun 30, 2020
Merged

bpo-40275: Use new test.support helper submodules in tests #21219

vstinner merged 1 commit into from
Jun 30, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jun 29, 2020 •
edited by bedevere-bot
Loading

Use test helpers in the following test cases and test framework:

  • audiotests
  • libregrtest
  • test_aifc
  • test_bz2
  • test_functools
  • test_future
  • test_logging
  • test_poll
  • test_regrtest
  • test_smtpd
  • test_time
  • test_unicode_file
  • test_urllib
  • test_zipimport_support

https://bugs.python.org/issue40275

@shihai1991
Copy link
Member Author

shihai1991 commented Jun 29, 2020

@vstinner Hi, victor. pls take a look if you have free time.

@brettcannon brettcannon removed their request for review June 29, 2020 19:03
vstinner
vstinner approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 3ddc634 into python:master Jun 30, 2020
@shihai1991
Copy link
Member Author

shihai1991 commented Jun 30, 2020

thanks, victor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@abalkin abalkin Awaiting requested review from abalkin

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@pganssle pganssle Awaiting requested review from pganssle

@rhettinger rhettinger Awaiting requested review from rhettinger

@vsajip vsajip Awaiting requested review from vsajip

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot