-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-23404: make regen-all What's New entry
#2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While the build changes won't affect most users, they may affect redistributors and folks building their own Python binaries from source.
|
Alternative proposal to #2127 |
|
I think this should be added also in What's New in 3.7. |
|
@serhiy-storchaka Agreed, but doing the different versions in different commits will make it easier to cherry-pick them to the applicable branches. |
|
(It's one of the few cases where I think cherry-picking forward into the development branch rather than backwards into the maintenance branches actually makes sense, as that way there can still be one combined PR to update 3.7) |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you mean a new title, ok. I prefer your wording and formatting than me ;-) LGTM.
|
|
||
| (Contributed by Victor Stinner in :issue:`23404`.) | ||
|
|
||
| .. versionadded:: 3.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, it's more versionchanged than versonadded, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regen-all is genuinely new, and attempting to use it on 3.6.0 or 3.61 will straight-up fail, so "added" seemed appropriate. I did use a "changed" marker on ``touch`, though (since we don't have a "removed" marker).
|
Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Sorry, @ncoghlan, I could not cleanly backport this to |
While the build changes won't affect most users,
they may affect redistributors and folks building
their own Python binaries from source.