Skip to content

Conversation

@ncoghlan
Copy link
Contributor

While the build changes won't affect most users,
they may affect redistributors and folks building
their own Python binaries from source.

While the build changes won't affect most users,
they may affect redistributors and folks building
their own Python binaries from source.
@ncoghlan
Copy link
Contributor Author

Alternative proposal to #2127

@serhiy-storchaka
Copy link
Member

I think this should be added also in What's New in 3.7.

@ncoghlan
Copy link
Contributor Author

@serhiy-storchaka Agreed, but doing the different versions in different commits will make it easier to cherry-pick them to the applicable branches.

@ncoghlan
Copy link
Contributor Author

(It's one of the few cases where I think cherry-picking forward into the development branch rather than backwards into the maintenance branches actually makes sense, as that way there can still be one combined PR to update 3.7)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you mean a new title, ok. I prefer your wording and formatting than me ;-) LGTM.


(Contributed by Victor Stinner in :issue:`23404`.)

.. versionadded:: 3.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, it's more versionchanged than versonadded, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regen-all is genuinely new, and attempting to use it on 3.6.0 or 3.61 will straight-up fail, so "added" seemed appropriate. I did use a "changed" marker on ``touch`, though (since we don't have a "removed" marker).

@ncoghlan ncoghlan merged commit e1b6903 into python:3.6 Jun 12, 2017
@miss-islington
Copy link
Contributor

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @ncoghlan, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e1b690370fd8f93bef1e69eeea2695f95a7cfff5 2.7

@ncoghlan ncoghlan deleted the issue23404-whats-new-update branch March 30, 2018 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants