Skip to content

[3.9] bpo-41194: The _ast module cannot be loaded more than once (GH-21290) #21292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Jul 3, 2020
Merged

[3.9] bpo-41194: The _ast module cannot be loaded more than once (GH-21290) #21292

vstinner merged 2 commits into from
Jul 3, 2020

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 3, 2020 •
edited by bedevere-bot
Loading

vstinner added 2 commits July 3, 2020 14:16
@vstinner
bpo-41194: Pass module state in Python-ast.c (GH-21284)
fe047be 
Rework asdl_c.py to pass the module state to functions in
Python-ast.c, instead of using astmodulestate_global.

Handle also PyState_AddModule() failure in init_types().

(cherry picked from commit 74419f0)
@vstinner
bpo-41194: The _ast module cannot be loaded more than once (GH-21290)
45c9584 
Fix a crash in the _ast module: it can no longer be loaded more than
once. It now uses a global state rather than a module state.

* Move _ast module state: use a global state instead.
* Set _astmodule.m_size to -1, so the extension cannot be loaded more
  than once.

(cherry picked from commit 91e1bc1)
@vstinner vstinner merged commit f859927 into python:3.9 Jul 3, 2020
@vstinner vstinner deleted the ast39 branch July 3, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot