bpo-28180: assume UTF-8 for Mac OS X PEP 538 tests #2130
Conversation
ncoghlan
changed the title
|
@Haypo, @ned-deily, @ronaldoussoren I think this should fix most of the current PEP 538 test failures on Mac OS X, except for the "LANG=UTF-8" one, where I'm not sure of the actual expected behaviour (I would have expected that to work, as even though (I haven't submitted it to the custom buildbot branch, as I'm about to head to bed, and don't want to claim the branch overnight). |
|
test_locale_c_coercion still fail on macOS with this change. Only FS encoding is always utf-8 on macOS, the locale encoding is still impacted by LC_ALL, LC_CTYPE and LANG. |
- clarify it's the default FS encoding we're checking - don't skip the whole module when no target locales are available - skip the explicit LANG=UTF-8 behaviour for now
ncoghlan
force-pushed
the
bpo-28180-fix-mac-os-x-test-errors
branch
from
ace589a to
e43b8ef
Compare
|
It looks like it's going to take the custom Mac OS X builder a while to catch up, so I'm going to go ahead and merge this, since it's at least less wrong than what's currently checked in (even though it doesn't fix the problems on FreeBSD). |
3 participants
No description provided.