bpo-39168: Remove the __new__ method of typing.Generic #21327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Jul 5, 2020
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks. I wonder if it's too late to backport to 3.9? It's late in the beta, but it's not adding a new feature, it's just a perf update. @ambv what do you think?
Member
|
Closing and reopening to make the test suite re-run. Don't be scared! |
Contributor
|
@ZackerySpytz: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
GH-21335 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 5, 2020
Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7fed755) Co-authored-by: Zackery Spytz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jul 5, 2020
Automerge-Triggered-By: @gvanrossum (cherry picked from commit 7fed755) Co-authored-by: Zackery Spytz <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jul 6, 2020
Automerge-Triggered-By: @gvanrossum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39168
Automerge-Triggered-By: @gvanrossum