bpo-32192: A basic lazy importer example #21330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrixise
approved these changes
Jul 6, 2020
Member
matrixise
left a comment
matrixise
left a comment
There was a problem hiding this comment.
Thank you for your proposal
matrixise
requested changes
Jul 6, 2020
Member
matrixise
left a comment
matrixise
left a comment
There was a problem hiding this comment.
sorry, I just clicked on the wrong button, but could you use an indent of 4 spaces. Thank you
|
When you're done making the requested changes, leave the comment: |
Contributor
Author
|
Done thanks for the review @matrixise |
merwok
reviewed
Jul 7, 2020
merwok
reviewed
Jul 7, 2020
merwok
reviewed
Jul 7, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
* Add example on lazy imports * Use four spaces for indentation * change to console
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
* Add example on lazy imports * Use four spaces for indentation * change to console
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
* Add example on lazy imports * Use four spaces for indentation * change to console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-author : Nick Coghlan (ncoghlan)
https://bugs.python.org/issue32192