bpo-29727: Register array.array as a MutableSequence #21338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandtbucher
approved these changes
Jul 5, 2020
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
I like the tests! Noticed one small opportunity to simplify the register call, but looks good either way:
| Py_DECREF((PyObject *)&Arraytype); | ||
| return -1; | ||
| } | ||
| PyObject *res = PyObject_CallMethod(mutablesequence, "register", "O", (PyObject *)&Arraytype); |
Member
There was a problem hiding this comment.
Suggested change
| PyObject *res = PyObject_CallMethod(mutablesequence, "register", "O", (PyObject *)&Arraytype); | |
| _Py_IDENTIFIER(register); | |
| PyObject *res = _PyObject_CallMethodIdOneArg(mutablesequence, &PyId_register, | |
| (PyObject *)&Arraytype); |
Member
Author
There was a problem hiding this comment.
Thanks, @brandtbucher. The reason I originally did not add _Py_IDENTIFIER is so we don't add more to the global/static state so it does not make future sub interpreters isolation harder, especially given that this code will run only at module import time.
Member
Author
|
Thanks for the review! |
This comment has been minimized.
This comment has been minimized.
Member
Author
The failure is unrelated to this PR:
|
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue29727