Skip to content

bpo-40275: Use new test.support helper submodules in tests #21452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Aug 4, 2020
Merged

bpo-40275: Use new test.support helper submodules in tests #21452

vstinner merged 2 commits into from
Aug 4, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jul 12, 2020 •
edited by bedevere-bot
Loading

Use test helpers in the following test cases:

  • tests of eintrdata
  • test_email
  • test_mmap
  • test_multibytecodec
  • test_pdb
  • test_urllib2_localnet
  • test_warnings
  • test_discovery
  • test_result

https://bugs.python.org/issue40275

@shihai1991 shihai1991 requested a review from a team as a code owner July 12, 2020 10:05
@shihai1991
Copy link
Member Author

shihai1991 commented Jul 12, 2020

cc @vstinner

@vstinner
Copy link
Member

vstinner commented Aug 3, 2020

It seems like they are now conflicts. Can you please fix them?

@shihai1991
Copy link
Member Author

shihai1991 commented Aug 4, 2020

It seems like they are now conflicts. Can you please fix them?

done.

@vstinner vstinner merged commit 604bba1 into python:master Aug 4, 2020
@shihai1991
Copy link
Member Author

shihai1991 commented Aug 4, 2020

thanks, victor.

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
37fb8f8 
…21452)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
d04cd16 
…21452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot