bpo-31904: disable os.popen and impacted test cases on VxWorks #21687
Conversation
pxinwr
force-pushed
the
fix-issue-31904-shell
branch
from
bcc5ef8 to
e37c536
Compare
pxinwr
changed the title
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Is this change a temporary workaround until subprocess is fixed on VxWorks, or is this skip supposed to be a temporary workaround?
If it's a temporary workaround, I am not sure if it's a good idea to document the skip.
Lib/os.py
Outdated
| "popen", "extsep"] | ||
| "extsep"] | ||
|
|
||
| VXWORKS = (sys.platform == 'vxworks') |
There was a problem hiding this comment.
This variable is only at a single place: you can remove it.
Lib/os.py
Outdated
| return None | ||
| if name == 'nt': | ||
| return returncode | ||
| if not VXWORKS: |
There was a problem hiding this comment.
I suggest: if sys.platform != 'vxworks':.
os.popen() runs cmd in shell, i.e. shell=True was set when calling subprocess.Popen(). VxWorks has no user space shell provided so that we can't create a new shell and run commands inside. For the subprocess module, VxWorks can't support features needing shell to run. So when I created this PR, I don't intend to be a temporary workaround. |
Co-authored-by: Victor Stinner <[email protected]>
|
Merged, thanks. |
5 participants
VxWorks has no user space shell provided so it can't support os.popen(). Disable it on VxWorks and impacted test cases.
https://bugs.python.org/issue41442