bpo-41513: Add docs and tests for hypot() #22238

rhettinger · 2020-09-14T05:21:27Z

https://bugs.python.org/issue41513

bedevere-bot · 2020-09-14T07:50:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit 457d4e9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/464/builds/73) and take a look at the build logs.
Check if the failure is related to this commit (457d4e9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/464/builds/73

Failed tests:

test_math

Failed subtests:

testHypotAccuracy - test.test_math.MathTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

1 test failed:
test_math

13 tests skipped:
test_asdl_parser test_check_c_globals test_clinic test_devpoll
test_gdb test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_math

Total duration: 33 min 52 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1064216818.6715267 != 1064216818.6715268


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1064635718.2516469 != 1064635718.251647


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1777447687.7070193 != 1777447687.707019


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1184594898.793983 != 1184594898.7939832


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1659295377.5212524 != 1659295377.5212526


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1012946124.895516 != 1012946124.8955162


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1281747081.1271062 != 1281747081.127106


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1760931563.0510736 != 1760931563.0510733


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.installed/build/target/lib/python3.10/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1046941197.716507 != 1046941197.7165071

bedevere-bot · 2020-09-14T08:05:45Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit 457d4e9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/73) and take a look at the build logs.
Check if the failure is related to this commit (457d4e9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/73

Failed tests:

test_math

Failed subtests:

testHypotAccuracy - test.test_math.MathTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

test_peg_generator: 10 min 36 sec
test_concurrent_futures: 5 min 13 sec
test_unparse: 3 min 50 sec
test_lib2to3: 3 min 16 sec
test_tokenize: 3 min 4 sec
test_multiprocessing_spawn: 2 min 9 sec
test_asyncio: 1 min 58 sec
test_unicodedata: 1 min 40 sec
test_multiprocessing_forkserver: 1 min 28 sec
test_venv: 1 min 20 sec

1 test failed:
test_math

10 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_startfile test_winconsoleio test_winreg test_winsound
test_zipfile64

1 re-run test:
test_math

Total duration: 36 min 5 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1046941197.716507 != 1046941197.7165071


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1184594898.793983 != 1184594898.7939832


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1777447687.7070193 != 1777447687.707019


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1760931563.0510736 != 1760931563.0510733


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1281747081.1271062 != 1281747081.127106


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1064635718.2516469 != 1064635718.251647


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1064216818.6715267 != 1064216818.6715268


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1012946124.895516 != 1012946124.8955162


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_math.py", line 855, in testHypotAccuracy
    self.assertEqual(hypot(x, y), z)
AssertionError: 1659295377.5212524 != 1659295377.5212526

bedevere-bot · 2020-09-14T10:17:20Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable 3.x has failed when building commit 457d4e9.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/125/builds/53) and take a look at the build logs.
Check if the failure is related to this commit (457d4e9) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/125/builds/53

Failed tests:

test_nntplib

Failed subtests:

test_with_statement - test.test_nntplib.NetworkedNNTP_SSLTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

409 tests OK.

10 slowest tests:

test_concurrent_futures: 4 min 52 sec
test_peg_generator: 3 min 17 sec
test_capi: 2 min 55 sec
test_unparse: 2 min 51 sec
test_multiprocessing_spawn: 2 min 48 sec
test_tokenize: 2 min 45 sec
test_asyncio: 2 min 29 sec
test_lib2to3: 1 min 57 sec
test_multiprocessing_forkserver: 1 min 47 sec
test_gdb: 1 min 31 sec

1 test failed:
test_nntplib

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 7 min 25 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_nntplib.py", line 293, in test_with_statement
    if re.search(r'(?i)KEY.TOO.SMALL', ssl_err.reason):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/re.py", line 201, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/test/test_nntplib.py", line 277, in test_with_statement
    server = self.NNTP_CLASS(self.NNTP_HOST,
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/nntplib.py", line 1025, in __init__
    super().__init__(host, port, user, password, readermode,
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/nntplib.py", line 334, in __init__
    self.sock = self._create_socket(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/nntplib.py", line 1031, in _create_socket
    sock = _encrypt_on(sock, self.ssl_context, self.host)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/nntplib.py", line 292, in _encrypt_on
    return context.wrap_socket(sock, server_hostname=hostname)
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64/build/Lib/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1122)

rhettinger added 10 commits September 6, 2020 12:21

Note performance aspects of using multiple accumulators

0f7a2ff

Add accuracy notes

7a29756

Show where each footnote applies

971ae45

Better wording for the incremental loop costs

080c68a

Improve wording for the accuracy paragraph

b6ecce6

Add test cases

f32a43d

Show subtest parameters in hex.

5c3413c

Improve comment

e9a4700

Remove doubt by computing reference values directly

f79dc78

Add documentation

8b20c2d

rhettinger added tests Tests in the Lib/test dir docs Documentation in the Doc dir skip news labels Sep 14, 2020

the-knights-who-say-ni added the CLA signed label Sep 14, 2020

bedevere-bot added the awaiting core review label Sep 14, 2020

rhettinger and others added 2 commits September 13, 2020 22:54

Fix order of references in notes

2862f26

Merge branch 'master' into hypot_notes

47bc660

rhettinger merged commit 457d4e9 into python:master Sep 14, 2020

bedevere-bot removed the awaiting core review label Sep 14, 2020

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41513: Add docs and tests for hypot() (pythonGH-22238)

5e9f283

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-41513: Add docs and tests for hypot() #22238

bpo-41513: Add docs and tests for hypot() #22238

Uh oh!

rhettinger commented Sep 14, 2020 •

edited by bedevere-bot

Loading

Uh oh!

bedevere-bot commented Sep 14, 2020

Uh oh!

bedevere-bot commented Sep 14, 2020

Uh oh!

bedevere-bot commented Sep 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

bpo-41513: Add docs and tests for hypot() #22238

bpo-41513: Add docs and tests for hypot() #22238

Uh oh!

Conversation

rhettinger commented Sep 14, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Sep 14, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 14, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 14, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rhettinger commented Sep 14, 2020 •

edited by bedevere-bot

Loading