Skip to content

bpo-41756: Refactor gen_send_ex(). #22330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Sep 22, 2020
Merged

bpo-41756: Refactor gen_send_ex(). #22330

serhiy-storchaka merged 1 commit into from
Sep 22, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 20, 2020 •
edited by bedevere-bot
Loading

1st1
1st1 reviewed Sep 20, 2020
View reviewed changes
Objects/genobject.c
static PyObject *
gen_send_ex(PyGenObject *gen, PyObject *arg, int exc, int closing, int *is_return_value)
static PySendResult
gen_send_ex2(PyGenObject *gen, PyObject *arg, PyObject **presult,
Copy link
Member

@1st1 1st1 Sep 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this function gen_send.

1st1
1st1 approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd name the function differently.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Sep 20, 2020

gen_send is the natural name of the implementation of the send() method. Currently it is named _PyGen_Send, but this API function will be replaced with PyGen_Send (and later with PyIter_Send).

@serhiy-storchaka serhiy-storchaka merged commit 6c33385 into python:master Sep 22, 2020
@serhiy-storchaka serhiy-storchaka deleted the gen-send-ex branch September 22, 2020 05:08
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@serhiy-storchaka
bpo-41756: Refactor gen_send_ex(). (pythonGH-22330)
f37cb91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @1st1 @the-knights-who-say-ni @bedevere-bot