Skip to content

[3.5] bpo-29887: Test normalization now fails if download fails (GH-905) #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 3 commits into from
Jun 20, 2017
Merged

[3.5] bpo-29887: Test normalization now fails if download fails (GH-905) #2272

vstinner merged 3 commits into from
Jun 20, 2017

Conversation

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Jun 19, 2017

  • test_normalization fails if download fails

bpo-29887. The test is still skipped if "-u urlfetch" option is not
passed to regrtest (python3 -m test -u urlfetch test_normalization).

  • Fix ResourceWarning in test_normalization

bpo-29887: Fix ResourceWarning in test_normalization if tests are
interrupted by CTRL+c.
(cherry picked from commit 722a3af)

@vstinner @Mariatta
[3.5] bpo-29887: Test normalization now fails if download fails (pyth…
1c98792 
…onGH-905)

* test_normalization fails if download fails

bpo-29887. The test is still skipped if "-u urlfetch" option is not
passed to regrtest (python3 -m test -u urlfetch test_normalization).

* Fix ResourceWarning in test_normalization

bpo-29887: Fix ResourceWarning in test_normalization if tests are
interrupted by CTRL+c.
(cherry picked from commit 722a3af)
@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2017
Merged
@vstinner
Copy link
Member

vstinner commented Jun 19, 2017

Strange, Travis CI failed on an unrelated test:

======================================================================

FAIL: test_write_filtered_python_package (test.test_zipfile.PyZipFileTests)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/python/cpython/Lib/test/test_zipfile.py", line 811, in test_write_filtered_python_package

    self.assertTrue('SyntaxError' not in reportStr)

AssertionError: False is not true

@vstinner vstinner mentioned this pull request Jun 19, 2017
Merged
vstinner
vstinner requested changes Jun 19, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must also cherry-pick d13d547: see my PR #2275.

vstinner and others added 2 commits June 19, 2017 20:31
@vstinner @Mariatta
bpo-29887: test_normalization handles PermissionError (python#1196)
edb6a0a 
Skip test_normalization.test_main() if download raises a permission
error.
(cherry picked from commit d13d547)
@Mariatta
no f-strings :(
957315e
@Mariatta
Copy link
Member Author

Mariatta commented Jun 20, 2017

Thanks @Haypo :) I cherry-picked d13d547.
Since f-strings don't work in this branch, I used %s to format the string.

@vstinner vstinner merged commit 070ba85 into python:3.5 Jun 20, 2017
@vstinner
Copy link
Member

vstinner commented Jun 20, 2017

Thanks for the backport @Mariatta !

@Mariatta Mariatta deleted the backport-722a3af-3.5 branch June 20, 2017 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mariatta @vstinner @the-knights-who-say-ni