-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-30616: Functional API of enum allows to create empty enums. #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ethanfurman Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good. Please add one more test for:
Thing = enum.Enum('Thing', [])
|
@ethanfurman Updated! Need to backport for 3.6? |
ethanfurman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thank you.
move addition to avoid conflict
|
GH-2324 is a backport of this pull request to the 3.6 branch. |
|
Add 3.5 backport label since 3.5 is still open to bug fixes. |
|
GH-2888 is a backport of this pull request to the 3.5 branch. |
bpo-30616: Functional API of enum allows to create empty enums.