[3.9] bpo-42103: Improve validation of Plist files. (GH-22882) #23115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent some possible DoS attacks via providing invalid Plist files with extremely large number of objects or collection sizes. * Raise InvalidFileException for too large bytes and string size instead of returning garbage. * Raise InvalidFileException instead of ValueError for specific invalid datetime (NaN). * Raise InvalidFileException instead of TypeError for non-hashable dict keys. * Add more tests for invalid Plist files. (cherry picked from commit 34637a0) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot
added
type-bug
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
serhiy-storchaka
approved these changes
Nov 2, 2020
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with extremely large number of objects or collection sizes.
(cherry picked from commit 34637a0)
Co-authored-by: Serhiy Storchaka [email protected]
https://bugs.python.org/issue42103