Skip to content

[3.9] bpo-41686: Always create the SIGINT event on Windows (GH-23344) #23347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Nov 17, 2020
Merged

[3.9] bpo-41686: Always create the SIGINT event on Windows (GH-23344) #23347

vstinner merged 1 commit into from
Nov 17, 2020

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 17, 2020 •
edited by bedevere-bot
Loading

bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

https://bugs.python.org/issue41686

@vstinner
bpo-41686: Always create the SIGINT event on Windows (GH-23344)
4b93536 
bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).
@vstinner vstinner merged commit 05a5d69 into python:3.9 Nov 17, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Nov 17, 2020

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the sigint_event39 branch November 17, 2020 17:58
@miss-islington
Copy link
Contributor

miss-islington commented Nov 17, 2020

Sorry, @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 05a5d697f4f097f37c5c1e2ed0e2338a33c3fb6a 3.8

@bedevere-bot
Copy link

bedevere-bot commented Nov 17, 2020

GH-23349 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Nov 17, 2020
@vstinner
bpo-41686: Always create the SIGINT event on Windows (GH-23344) (GH-2…
a702bd4 
…3347) (GH-23349)

bpo-41686, bpo-41713: On Windows, the SIGINT event,
_PyOS_SigintEvent(), is now created even if Python is configured to
not install signal handlers (PyConfig.install_signal_handlers=0 or
Py_InitializeEx(0)).

(cherry picked from commit 05a5d69)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni