[security][3.4] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gvanrossum, @gpshead and @tim-one to be potential reviewers. |
…s on Windows. (pythonGH-2325) Prevent passing other invalid environment variables and command arguments.. (cherry picked from commit d174d24)
serhiy-storchaka
force-pushed
the
backport-d174d24-3.4
branch
from
ed4e0c7 to
1be314a
Compare
vstinner
changed the title
vstinner
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)