Skip to content

[3.7] bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) #24041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ned-deily merged 1 commit into from
Jan 1, 2021
Merged

[3.7] bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) #24041

ned-deily merged 1 commit into from
Jan 1, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 1, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na [email protected]

https://bugs.python.org/issue42794

@bedevere-bot bedevere-bot mentioned this pull request Jan 1, 2021
Merged
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 1, 2021
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 1, 2021

@corona10: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 1, 2021

@corona10: Status check is done, and it's a success ✅ .

corona10
corona10 approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm bot

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 1, 2021

@corona10: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 1, 2021

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@corona10 corona10 requested a review from ned-deily January 1, 2021 15:30
@corona10
Copy link
Member

corona10 commented Jan 1, 2021

@ned-deily
I add the backport label for 3.7 and 3.6 also.
We often send backport patches for security issues but this issue breaks 3.7 and 3.6 testing also.
If there are other opinions please let me know.

@ned-deily ned-deily merged commit 8200ee6 into python:3.7 Jan 1, 2021
@miss-islington miss-islington deleted the backport-ec31653-3.7 branch January 1, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @corona10 @ned-deily @the-knights-who-say-ni @bedevere-bot