bpo-42195: Disallow isinstance/issubclass for subclasses of genericaliases in Union #24059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I think we can skip news, the code was valid up till before PR-23060 so it can share the same news as that one. |
gvanrossum
approved these changes
Jan 2, 2021
gvanrossum
approved these changes
Jan 2, 2021
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…iases in Union (pythonGH-24059) Previously this didn't raise an error. Now it will: ```python from collections.abc import Callable isinstance(int, list | Callable[..., str]) ``` Also added tests in Union since there were previously none for stuff like ``isinstance(list, list | list[int])`` either. Backport to 3.9 not required. Automerge-Triggered-By: GH:gvanrossum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this didn't raise an error. Now it will:
Also added tests in Union since there were previously none for stuff like
isinstance(list, list | list[int])either.Backport to 3.9 not required.
https://bugs.python.org/issue42195
Automerge-Triggered-By: GH:gvanrossum