bpo-42882: Fix compiler warnings in MSVC #24440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
changed the title
Member
|
Merged, thanks. |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
_PyRuntimeState.unicode_ids.next_index type is Py_ssize_t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MSVC, I get warnings during compilation:
1>\Documents\GitHub\cpython\Python\pystate.c(96,57): warning C4244: '=': conversion from 'int64_t' to 'Py_ssize_t', possible loss of data.It seems that
runtime->unicode_ids.next_indexis type Py_ssize_t, not int64_t.This was introduced in 44bf57a which only exists in 3.10, so no backport required.
cc @vstinner
https://bugs.python.org/issue42882