bpo-43277: Add PySet_CheckExact to the C-API #24598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
requested review from
markshannon,
methane and
rhettinger
as code owners
vstinner
approved these changes
Feb 20, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, I just left a minor comment :-p
Co-authored-by: Victor Stinner <[email protected]>
Contributor
|
@pablogsal: Status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
|
@pablogsal: Status check is done, and it's a failure ❌ . |
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Feb 20, 2021
bpo-43277: Add PySet_CheckExact to the C-API (pythonGH-24598)
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
For some mysterious reason we have PySet_Check, PyFrozenSet_Check, PyAnySet_Check, PyAnySet_CheckExact and PyFrozenSet_CheckExact but no PySet_CheckExact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some mysterious reason we have
PySet_Check,PyFrozenSet_Check,PyAnySet_Check,PyAnySet_CheckExactandPyFrozenSet_CheckExactbut noPySet_CheckExactAutomerge-Triggered-By: GH:pablogsal