Skip to content

Conversation

@nascheme
Copy link
Member

@nascheme nascheme commented Feb 21, 2021

Github rebase put the skip() method in the wrong place. Fix it.

https://bugs.python.org/issue43288

@miss-islington
Copy link
Contributor

Thanks @nascheme for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @nascheme, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 84f7afe65c29330f3ff8e318e054b96554a2dede 3.9

nascheme added a commit that referenced this pull request Feb 21, 2021
nascheme added a commit that referenced this pull request Feb 21, 2021
* bpo-43288: Fix bug in test_importlib test. (GH-24612)
* Fix failed merge of bpo-43288. (GH-24614)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@terryjreedy
Copy link
Member

The backport attempt was a mistake because the original PR that this fixes was never merged into 3.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants