-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-42128: Add Pattern Matching to What's New #24667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ramalho If you get a chance, please take a look. Thanks! |
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much Carol! I found a few markup mistakes and have a few more editorial suggestions.
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hit Submit too soon, here are the last three review items. Goodnight!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read everything in detail, but here's a bunch of suggestions to get the CI checks to pass :).
(mostly just whitespace fixes)
KunKax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on having Scala *and *Elixir.
|
Great quick intro, @willingc thanks! I think the special variable I think it would help readers if that example could appear after an example with Also, as @gvanrossum suggested, it's important to have an example without |
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
|
Thanks @gvanrossum, @ramalho, and others who helped review this PR. Your feedback improved the content which should help users with understanding. |
|
You're welcome! @willingc Go ahead and land it. |
|
@willingc: Please replace |
https://bugs.python.org/issue42128