-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-30805: Avoid race condition of self._debug in event loop
#2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If a process is schedule to run in the event loop with debug disabled and debug is then enabled before the process finishes it will result in a traceback: log_debug undefined.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
self._debug in event loopself._debug in event loop
|
CLA signed. I dont know how to update that tag. Just prod the bot @the-knights-who-say-ni ? |
methane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Closing this PR in favour of #7545 as we don't have time to iterate on this patch before 3.7.0rc1. |
Supersedes python#2490 (cherry picked from commit 12f482e) Co-authored-by: Yury Selivanov <[email protected]>
Supersedes python#2490 (cherry picked from commit 12f482e) Co-authored-by: Yury Selivanov <[email protected]>
Supersedes #2490 (cherry picked from commit 12f482e) Co-authored-by: Yury Selivanov <[email protected]>
Supersedes #2490 (cherry picked from commit 12f482e) Co-authored-by: Yury Selivanov <[email protected]>
If a process is schedule to run in the event loop with debug disabled
and debug is then enabled before the process finishes it will result in
a traceback: log_debug undefined.