Skip to content

[3.9] bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) #25437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Apr 16, 2021
Merged

[3.9] bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) #25437

vstinner merged 1 commit into from
Apr 16, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 16, 2021 •
edited by bedevere-bot
Loading

Fix a race condition in the SMTP test of test_logging. Don't close a
file descriptor (socket) from a different thread while
asyncore.loop() is polling the file descriptor.

(cherry picked from commit 75ec103)

https://bugs.python.org/issue43842

@vstinner
bpo-43842: Fix race condition in test_logging SMTP test (GH-25436)
65b1731 
Fix a race condition in the SMTP test of test_logging. Don't close a
file descriptor (socket) from a different thread while
asyncore.loop() is polling the file descriptor.

(cherry picked from commit 75ec103)
@vstinner vstinner requested a review from vsajip as a code owner April 16, 2021 12:36
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Apr 16, 2021
@vstinner vstinner changed the title bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) [3.9] bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) Apr 16, 2021
@vstinner vstinner merged commit e1903e1 into python:3.9 Apr 16, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Apr 16, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the fix_test_loggin39 branch April 16, 2021 14:06
@miss-islington
Copy link
Contributor

miss-islington commented Apr 16, 2021

Sorry, @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e1903e11a3d42512effe336026e0c67f602e5848 3.8

@bedevere-bot
Copy link

bedevere-bot commented Apr 16, 2021

GH-25440 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Apr 16, 2021
@vstinner
bpo-43842: Fix race condition in test_logging SMTP test (GH-25436) (G…
816da33 
…H-25437) (GH-25440)

Fix a race condition in the SMTP test of test_logging. Don't close a
file descriptor (socket) from a different thread while
asyncore.loop() is polling the file descriptor.

(cherry picked from commit 75ec103)
(cherry picked from commit e1903e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

@vstinner vstinner

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni