Skip to content

bpo-43124: Fix smtplib multiple CRLF injection #25987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 3 commits into from
Aug 29, 2021
Merged

bpo-43124: Fix smtplib multiple CRLF injection #25987

ambv merged 3 commits into from
Aug 29, 2021

Conversation

@miguendes
Copy link
Contributor

@miguendes miguendes commented May 8, 2021 •
edited by bedevere-bot
Loading

@miguendes miguendes requested a review from a team as a code owner May 8, 2021 10:53
@Fidget-Spinner Fidget-Spinner added the type-security A security issue label May 8, 2021
@ned-deily
Copy link
Member

ned-deily commented May 21, 2021

Thanks for the PR! Can someone from @python/email-team take a look at it?

@github-actions
Copy link

github-actions bot commented Jun 21, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 21, 2021
bitdancer
bitdancer reviewed Jul 13, 2021
View reviewed changes
@ambv ambv removed the stale Stale PR or inactive for long period of time. label Aug 29, 2021
@ambv ambv merged commit 0897253 into python:main Aug 29, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Aug 29, 2021

Thanks @miguendes for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2021
@miguendes @miss-islington
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987)
2e965cf 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 29, 2021
@bedevere-bot
Copy link

bedevere-bot commented Aug 29, 2021

GH-28034 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2021
@miguendes @miss-islington
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987)
9c97071 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 29, 2021

GH-28035 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2021
@miguendes @miss-islington
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987)
b6536b6 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 29, 2021

GH-28036 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2021
@miguendes @miss-islington
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987)
fa4ab4f 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 29, 2021

GH-28037 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2021
@miguendes @miss-islington
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987)
f43b8d4 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 29, 2021

GH-28038 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Aug 29, 2021
@miss-islington @miguendes
bpo-43124: Fix smtplib multiple CRLF injection (GH-25987)
9e6c317 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
ambv pushed a commit that referenced this pull request Aug 29, 2021
@miss-islington @miguendes
bpo-43124: Fix smtplib multiple CRLF injection (GH-25987) (GH-28035)
24416e4 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
ambv pushed a commit that referenced this pull request Aug 29, 2021
@miss-islington @miguendes
[3.8] bpo-43124: Fix smtplib multiple CRLF injection (GH-25987) (GH-2…
b93aea4 
…8036)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

Co-authored-by: Miguel Brito <[email protected]>
ned-deily pushed a commit that referenced this pull request Aug 30, 2021
@miss-islington @ambv
[3.7] bpo-43124: Fix smtplib multiple CRLF injection (GH-25987) (GH-2…
d2cc04c 
…8037)

Co-authored-by: Miguel Brito <[email protected]>

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)
ned-deily pushed a commit that referenced this pull request Aug 30, 2021
@miss-islington @ambv
[3.6] bpo-43124: Fix smtplib multiple CRLF injection (GH-25987) (GH-2…
29d97d1 
…8038)

Co-authored-by: Miguel Brito <[email protected]>

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Aug 31, 2021
@miss-islington @mgorny
bpo-43124: Fix smtplib multiple CRLF injection (pythonGH-25987) (pyth…
11afbbe 
…onGH-28038)

Co-authored-by: Miguel Brito <[email protected]>

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 0897253)

(updated for 2.7 by Michał Górny)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer left review comments

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@miguendes @ned-deily @miss-islington @bedevere-bot @bitdancer @ambv @corona10 @the-knights-who-say-ni @Fidget-Spinner