-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor inaccuracies in news #26096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that the failure to raise only applied to Protocols with (only?) data items declared?
Yes. I'll update this by tomorrow (your time). |
Hi @Pretty-19 , thanks for your interest in contributing to Python. The official guide for CPython development is the devguide https://devguide.python.org/. It does a way better job answering your questions than I can. Personally I also recommend https://realpython.com/start-contributing-python/ . It's much easier to follow for a completely new contributor. BTW, you'll learn of better avenues to get help if you read those resources. Asking on a random pull request may not always be conducive (unless your question relates to the PR itself)! |
Co-authored-by: Guido van Rossum <[email protected]>
|
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
…ccuracies in news (pythonGH-26096) The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that. (cherry picked from commit 8450e8a) Co-authored-by: Ken Jin <[email protected]>
|
GH-26337 is a backport of this pull request to the 3.10 branch. |
…nor inaccuracies in news (GH-26096) (GH-26337) The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that. (cherry picked from commit 8450e8a) Co-authored-by: Ken Jin <[email protected]>
The fix only applies to
isinstance.issubclassisn't affected (because it was always working to begin with). So I also fixed the news to reflect that.https://bugs.python.org/issue38908
Automerge-Triggered-By: GH:gvanrossum