Skip to content

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 13, 2021

The fix only applies to isinstance. issubclass isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.

https://bugs.python.org/issue38908

Automerge-Triggered-By: GH:gvanrossum

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 13, 2021
@Fidget-Spinner Fidget-Spinner changed the title bpo-38908: Add changes to 3.10 whatsnew and fix some minor inaccuracies in news bpo-38908: [docs] Add changes to 3.10 whatsnew and fix some minor inaccuracies in news May 13, 2021
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.10 only security fixes label May 13, 2021
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the failure to raise only applied to Protocols with (only?) data items declared?

@Fidget-Spinner
Copy link
Member Author

I thought that the failure to raise only applied to Protocols with (only?) data items declared?

Yes. I'll update this by tomorrow (your time).

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 14, 2021

@Fidget-Spinner wanted to know if there is a discord or community page for python contributors? Also how does one go about starting the process of contribution like finding an issue with such a repo?

Hi @Pretty-19 , thanks for your interest in contributing to Python. The official guide for CPython development is the devguide https://devguide.python.org/. It does a way better job answering your questions than I can.

Personally I also recommend https://realpython.com/start-contributing-python/ . It's much easier to follow for a completely new contributor.

BTW, you'll learn of better avenues to get help if you read those resources. Asking on a random pull request may not always be conducive (unless your question relates to the PR itself)!

Co-authored-by: Guido van Rossum <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2021
…ccuracies in news (pythonGH-26096)

The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.
(cherry picked from commit 8450e8a)

Co-authored-by: Ken Jin <[email protected]>
@bedevere-bot
Copy link

GH-26337 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 24, 2021
miss-islington added a commit that referenced this pull request May 27, 2021
…nor inaccuracies in news (GH-26096) (GH-26337)

The fix only applies to ``isinstance``. ``issubclass`` isn't affected (because it was always working to begin with). So I also fixed the news to reflect that.
(cherry picked from commit 8450e8a)


Co-authored-by: Ken Jin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants