[3.10] bpo-11105: Do not crash when compiling recursive ASTs (GH-20594) #26521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling an AST object with a direct / indirect reference cycles, on the conversion phase because of exceeding amount of calls, a segfault was raised. This patch adds recursion guards to places for preventing user inputs to not to crash AST but instead raise a RecursionError. (cherry picked from commit f349124) Co-authored-by: Batuhan Taskaya <[email protected]>
Contributor
Author
|
@isidentical and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@isidentical and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@isidentical and @pablogsal: Status check is done, and it's a success ✅ . |
pablogsal
approved these changes
Jun 3, 2021
isidentical
approved these changes
Jun 3, 2021
Contributor
Author
|
@isidentical and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@isidentical and @pablogsal: Status check is done, and it's a pending ❌ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling an AST object with a direct / indirect reference
cycles, on the conversion phase because of exceeding amount of
calls, a segfault was raised. This patch adds recursion guards to
places for preventing user inputs to not to crash AST but instead
raise a RecursionError.
(cherry picked from commit f349124)
Co-authored-by: Batuhan Taskaya [email protected]
https://bugs.python.org/issue11105