Skip to content

[3.10] bpo-43219: shutil.copyfile, raise a less confusing exception instead of IsADirectoryError (GH-27049) #27081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 1 commit into from
Jul 10, 2021
Merged

[3.10] bpo-43219: shutil.copyfile, raise a less confusing exception instead of IsADirectoryError (GH-27049) #27081

miss-islington merged 1 commit into from
Jul 10, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 10, 2021 •
edited
Loading

Fixes the misleading IsADirectoryError to be FileNotFoundError.
(cherry picked from commit 248173c)

Co-authored-by: andrei kulakov [email protected]

https://bugs.python.org/issue43219

Automerge-Triggered-By: GH:gpshead

@akulakov @miss-islington
bpo-43219: shutil.copyfile, raise a less confusing exception instead …
c264d9d 
…of IsADirectoryError (pythonGH-27049)

Fixes the misleading IsADirectoryError to be FileNotFoundError.
(cherry picked from commit 248173c)

Co-authored-by: andrei kulakov <[email protected]>
@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 10, 2021

@akulakov and @gpshead: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Jul 10, 2021
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 10, 2021

@akulakov and @gpshead: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Jul 10, 2021
@miss-islington
Copy link
Contributor Author

miss-islington commented Jul 10, 2021

@akulakov and @gpshead: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1577259 into python:3.10 Jul 10, 2021
@miss-islington miss-islington deleted the backport-248173c-3.10 branch July 10, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot @akulakov