Skip to content

bpo-44490: Add 'Whats New' docs regarding types.Union changes #27215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ambv merged 4 commits into from
Jul 26, 2021
Merged

bpo-44490: Add 'Whats New' docs regarding types.Union changes #27215

ambv merged 4 commits into from
Jul 26, 2021

Conversation

@uriyyo
Copy link
Member

@uriyyo uriyyo commented Jul 17, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 17, 2021
@uriyyo
Copy link
Member Author

uriyyo commented Jul 17, 2021

@Fidget-Spinner Could you please review What's new? I believe you can improve what I wrote)

And also, could you please add skip-news label?

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jul 17, 2021 •
edited
Loading

I'm really sorry, but Serhiy may be backporting the change to 3.10. In which case we won't need to add a whats new for 3.11.

If his backport lands, please instead add your name to the whats new in 3.10 https://docs.python.org/3.10/whatsnew/3.10.html#pep-604-new-type-union-operator. (the part mentioning Maggie and Phillipe). I think you've earned it :).

@uriyyo
Copy link
Member Author

uriyyo commented Jul 17, 2021

Okay, thats makes sense. Let's wait for Serhiy changes.

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jul 18, 2021

Ok, Serhiy has landed his 3.10 backports so we don't need the what's new in 3.11 anymore. Please credit him and yourself in the 3.10 whats new. Maybe (Contributed by Maggie Moss and Philippe Prados in :issue:`41428`, with additions by Yurii Karabas and Serhiy Storchaka in :issue:`44490`.)?

@Fidget-Spinner Fidget-Spinner added the needs backport to 3.10 only security fixes label Jul 19, 2021
@ambv ambv merged commit 6c1b57d into python:main Jul 26, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jul 26, 2021

Thanks @uriyyo for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2021

GH-27368 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
@uriyyo @miss-islington
bpo-44490: Add 'Whats New' docs regarding types.Union changes (python…
e5552d8 
…GH-27215)

(cherry picked from commit 6c1b57d)

Co-authored-by: Yurii Karabas <[email protected]>
ambv pushed a commit that referenced this pull request Jul 26, 2021
@miss-islington @uriyyo
bpo-44490: Add 'Whats New' docs regarding types.Union changes (GH-27215…
4a5457d 
…) (GH-27368)

(cherry picked from commit 6c1b57d)

Co-authored-by: Yurii Karabas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uriyyo @Fidget-Spinner @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni