Skip to content

bpo-44872: use new trashcan macros in framobject.c #27683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 2 commits into from
Aug 9, 2021
Merged

bpo-44872: use new trashcan macros in framobject.c #27683

iritkatriel merged 2 commits into from
Aug 9, 2021

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 9, 2021 •
edited by bedevere-bot
Loading

@iritkatriel iritkatriel requested a review from pablogsal August 9, 2021 16:16
pablogsal
pablogsal approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iritkatriel for the PR!

@iritkatriel
Copy link
Member Author

iritkatriel commented Aug 9, 2021

Should we backport this? The issue goes back to 3.8 so I think yes.

@pablogsal
Copy link
Member

pablogsal commented Aug 9, 2021

For 3.10 for sure, for 3.9 and 3.8 I think we should but we should check first with @ambv

@ambv
Copy link
Contributor

ambv commented Aug 9, 2021

Segfaulting the interpreter with code that worked fine in 3.7 sounds like a potential security-grade bug. Thus, please backport to 3.8 as well.

@iritkatriel iritkatriel merged commit 7d14fdb into python:main Aug 9, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Aug 9, 2021

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 9, 2021

@iritkatriel: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

miss-islington commented Aug 9, 2021

Sorry, @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d14fdb03c3e8384c01da1b21647ce837ed6a29c 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Aug 9, 2021

Sorry @iritkatriel, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7d14fdb03c3e8384c01da1b21647ce837ed6a29c 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Aug 9, 2021

Sorry, @iritkatriel, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7d14fdb03c3e8384c01da1b21647ce837ed6a29c 3.8

@iritkatriel iritkatriel deleted the bpo-44872 branch August 9, 2021 17:23
sthagen added a commit to sthagen/python-cpython that referenced this pull request Aug 9, 2021
@sthagen
Merge pull request #590 from python/main
83baf64 
bpo-44872: use new trashcan macros in framobject.c (python#27683)
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 9, 2021
@iritkatriel
bpo-44872: use new trashcan macros in framobject.c (pythonGH-27683)
93e773e
@bedevere-bot
Copy link

bedevere-bot commented Aug 9, 2021

GH-27690 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 9, 2021
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Aug 9, 2021
@iritkatriel
bpo-44872: use new trashcan macros in framobject.c (pythonGH-27683)
c8743be
@bedevere-bot
Copy link

bedevere-bot commented Aug 9, 2021

GH-27691 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Aug 9, 2021

GH-27692 is a backport of this pull request to the 3.8 branch.

ambv pushed a commit that referenced this pull request Aug 10, 2021
@iritkatriel
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27691)
ede1dc4
ambv pushed a commit that referenced this pull request Aug 10, 2021
@iritkatriel
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27692)
b019ffe
ambv pushed a commit that referenced this pull request Aug 10, 2021
@iritkatriel
bpo-44872: use new trashcan macros in framobject.c (GH-27683) (GH-27690)
e9ec71a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@iritkatriel iritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @pablogsal @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni