bpo-45034: Fixes how upper limit is formatted for struct.pack("H", ...)

[sobolevn]

https://bugs.python.org/issue45034

It was:

struct.error: ushort format requires 0 <= number <= (0x7fff * 2 + 1)

It is now:

struct.error: ushort format requires 0 <= number <= 65535

[mdickinson]

Thanks for the PR. I think we should extend the fix to np_short, too: those uses of Py_STRINGIFY never really made much sense.

[sobolevn]

I think we should extend the fix to np_short, too: those uses of Py_STRINGIFY never really made much sense.

Will do! Thanks a lot for your help 👍

[mdickinson]

LGTM; thank you! Do you want to add your name to the list in Misc/ACKS? (It's entirely optional.)

[sobolevn]

Do you want to add your name to the list in Misc/ACKS?

Why not? 😄 Added!

Thanks a lot for your help! 👍

[serhiy-storchaka]

What about other integer and floating point types?

[mdickinson]

What about other integer and floating point types?

I think we can leave broader changes for a separate PR, if anyone feels inclined; this PR addresses the immediate issue that @stevendaprano was seeing, which was due to inappropriate uses of Py_STRINGIFY.

[sobolevn]

Let's have an explicit cast then 🙂