[2.7] bpo-30119: fix ftplib.FTP.putline() to throw an error for a illegal command (#1214) #2894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jul 26, 2017
Lib/test/test_ftplib.py
Outdated
Member
There was a problem hiding this comment.
What is the rationale for this change? It seems specific to Python 3 where all OS-like exceptions have be replaced by a single OSError. On Python 2.7, you really want IOError. Please revert this change, to repair failing tests.
Member
Author
There was a problem hiding this comment.
@Haypo Oh, you are right. Thank you for comment.
Member
Author
|
Updated |
Member
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick from 2b1e6e9
https://bugs.python.org/issue30119