[2.7] bpo-25684: ttk.OptionMenu radiobuttons weren't unique (GH-2276) #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
between instances of OptionMenu. (cherry picked from commit a568e52)
Contributor
Author
|
@serhiy-storchaka This was a challenge because of the conflicts, but I think it's right. I'm not really comfortable adding my name to the Misc/ACKS for 2.7 since it's just one change, and so many others have made a lot more contributions. I hope that's OK. If not, I'll add it. |
csabella
changed the title
terryjreedy
changed the title
terryjreedy
changed the title
Member
|
I edited title to poke Bedevere into rechecking. I had to actually make a change to make that work ;-). |
terryjreedy
approved these changes
Jul 31, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I think this qualifies you for acks. Up to you. Otherwise, looks good.
Contributor
Author
|
I've changed Misc/ACKS. My rationalization is that I'll just have to make another change that gets into 2.7. :-) |
Contributor
Author
|
@serhiy-storchaka Did you want this included in the new 2.7 release that's coming up? Thanks. |
Mariatta
approved these changes
Sep 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
between instances of OptionMenu.
(cherry picked from commit a568e52)
https://bugs.python.org/issue25684