Skip to content

bpo-31083: IDLE: Document TabPage(Frame) for configdialog #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 4 commits into from
Aug 1, 2017
Merged

bpo-31083: IDLE: Document TabPage(Frame) for configdialog #2965

terryjreedy merged 4 commits into from
Aug 1, 2017

Conversation

@csabella
Copy link
Contributor

@csabella csabella commented Aug 1, 2017 •
edited by bedevere-bot
Loading

mlouielu
mlouielu reviewed Aug 1, 2017
View reviewed changes
Lib/idlelib/configdialog.py
indent_title.pack(side=TOP, anchor=W, padx=5)
self.indent_scale.pack(side=TOP, padx=5, fill=X)

return frame
Copy link
Contributor

@mlouielu mlouielu Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to return self?

Copy link
Member

@terryjreedy terryjreedy Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, because calling a class returns a new instance. In this case, the instance, self, is a frame. Create_widgets is now called within init (and the None return ignored) instead of by ConfigDialog.

Copy link
Contributor

@mlouielu mlouielu Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got it.

mlouielu
mlouielu approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@mlouielu mlouielu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@terryjreedy terryjreedy merged commit 6f446be into python:master Aug 1, 2017
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Aug 1, 2017
@csabella @terryjreedy
[3.6] bpo-31083: IDLE: Describe the Page classes in configdialog (pyt…
805b0a8 
…honGH-2965)

Add template as comment. Update existing classes to match outline.
Initial patch by Cheryl Sabella.
(cherry picked from commit 6f446be)
terryjreedy added a commit that referenced this pull request Aug 1, 2017
@terryjreedy
[3.6] bpo-31083: IDLE: Describe the Page classes in configdialog (GH-…
48fcc72 
…2965) (#2973)

Add template as comment. Update existing classes to match outline.
Initial patch by Cheryl Sabella.
(cherry picked from commit 6f446be)
@mlouielu
Copy link
Contributor

mlouielu commented Aug 1, 2017

@csabella Forgot to ask you, you can setup your name in GitHub settings，then inside the git log it will show up with this name.

Otherwise you name inside git log is using Author: csabella <[email protected]>. maybe Author: Cheryl Sabella <[email protected]> will be much better.

@csabella csabella deleted the bpo31083 branch August 1, 2017 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

+1 more reviewer

@mlouielu mlouielu mlouielu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csabella @mlouielu @terryjreedy @the-knights-who-say-ni