bpo-31070: Fix a race condition in importlib _get_module_lock(). #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.6
type-bug
vstinner
approved these changes
Aug 9, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, I just suggest to add a comment.
| def cb(ref, name=name): | ||
| _imp.acquire_lock() | ||
| try: | ||
| if _module_locks.get(name) is ref: |
Member
There was a problem hiding this comment.
I suggest to add a comment on the test. Something like:
# bpo-31070: Check if another thread created a new lock
# after the previous lock was destroyed
# but before the weakref callback was called
vstinner
approved these changes
Aug 9, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, thanks for the comment.
ncoghlan
approved these changes
Aug 9, 2017
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Thanks @serhiy-storchaka!
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Aug 9, 2017
pythonGH-3033). (cherry picked from commit 9b0d1d6)
|
GH-3038 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31070