bpo-46009: Remove GEN_START
#30367
Merged
bpo-46009: Remove GEN_START
#30367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Feel free to merge when you've updated the magic number and generated code. |
facebook-github-bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Oct 21, 2024
Summary: 3.12 got rid of `GEN_START` in favor of just doing a `POP_TOP`. It also added a new prefix instruction `RETURN_GENERATOR` for the start of generators. See also: python/cpython#30367 Reviewed By: alexmalyshev Differential Revision: D64254995 fbshipit-source-id: 642fce49e53ab16d179fd19276b52b34f391ce60
facebook-github-bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Oct 23, 2024
Summary: This brings back D64254995 unmodified. 3.12 got rid of `GEN_START` in favor of just doing a `POP_TOP`. It also added a new prefix instruction `RETURN_GENERATOR` for the start of generators. See also: python/cpython#30367 Reviewed By: jbower-fb Differential Revision: D64720557 fbshipit-source-id: 5bebe1643acc5a869cd93465f652d82292cf8de9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEN_STARThas been equivalent toPOP_TOPfor some time now.https://bugs.python.org/issue46009