bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise NotImplementedError | ||
|
|
||
| def call_at(self, when, callback, *args): | ||
| def call_at(self, when, callback, *args, cotext=None): |
Contributor
There was a problem hiding this comment.
Suggested change
| def call_at(self, when, callback, *args, cotext=None): | |
| def call_at(self, when, callback, *args, context=None): |
Contributor
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2022
…GH-30427) (cherry picked from commit 3e43fac) Co-authored-by: Andrew Svetlov <[email protected]>
|
GH-30428 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2022
…GH-30427) (cherry picked from commit 3e43fac) Co-authored-by: Andrew Svetlov <[email protected]>
|
GH-30429 is a backport of this pull request to the 3.9 branch. |
kumaraditya303
added a commit
to kumaraditya303/cpython
that referenced
this pull request
Jan 6, 2022
asvetlov
added a commit
that referenced
this pull request
Jan 6, 2022
…) (#30429) (cherry picked from commit 3e43fac) Co-authored-by: Andrew Svetlov <[email protected]> Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov
added a commit
that referenced
this pull request
Jan 6, 2022
…) (GH-30428) (cherry picked from commit 3e43fac) Co-authored-by: Andrew Svetlov <[email protected]> Co-authored-by: Andrew Svetlov <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov (cherry picked from commit b50e5e9) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
pushed a commit
that referenced
this pull request
Jan 6, 2022
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov (cherry picked from commit b50e5e9) Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov (cherry picked from commit b50e5e9) Co-authored-by: Kumar Aditya <[email protected]>
asvetlov
pushed a commit
that referenced
this pull request
Jan 6, 2022
Automerge-Triggered-By: GH:asvetlov (cherry picked from commit b50e5e9) Co-authored-by: Kumar Aditya <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46278