bpo-46301: remove refleak from Enum tests

[sobolevn]

It does not happen anymore, I've tested this locally using: PYTHONDUMPREFSFILE=ex.txt ./python.exe -m test -R : -v test_enum

Refs #30472

CC @ethanfurman and @pablogsal
And CC @corona10 as my mentor.

https://bugs.python.org/issue46301

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9b858f5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

[sobolevn]

Looks like the CI failed for some unrelated reasons:

https://buildbot.python.org/all/#/builders/470/builds/379

I will try to apply test-with-buildbots again once all others will finish.

[sobolevn]

Ok, buildbots take quite a long time to work (1h+). I hope that retriggering a single failing one is not so important. Other Refleak tests pass. So, I don't want to waste extra resources 🙂

[ethanfurman]

I like the solution.

While it pains me to say it, please fix the formatting.

[ethanfurman]

Do not use Black formatting on enum code, please. Continuation lines should be eight space indents, and each closing ), ], and } should line up as if it were code and not syntax, with the final line (if it introduces a block) only indented the normal four spaces. In other words:

a_long_list_comprehension = [
        x
        for x in spam(eggs, ham)
        if x not in some_previous_group
        ]

and

with yada(
        arg1, arg2, something_else=None,
    ):
    # body of code

[ethanfurman]

I like this. Please switch over the other _convert_ tests to use it, which will allow the removal of the setUp() methods in those tests.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[sobolevn]

Done! Code formatting is very important I (as a maintainer of ~10 different linters) can totally relate 😊

Thanks for the review!

To make bot happy:

I have made the requested changes; please review again

[ethanfurman]

I have made the requested changes; please review again

I think you forgot a period. ;-)