Skip to content

bpo-44133: Skip PyThread_get_thread_native_id() if not available #30636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Jan 17, 2022
Merged

bpo-44133: Skip PyThread_get_thread_native_id() if not available #30636

vstinner merged 1 commit into from
Jan 17, 2022

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 17, 2022 •
edited by bedevere-bot
Loading

test_capi.test_export_symbols() doesn't check if Python exports the
"PyThread_get_thread_native_id" symbol if the _thread.get_native_id()
function is not available (if the PY_HAVE_THREAD_NATIVE_ID macro is
not defined).

https://bugs.python.org/issue44133

@vstinner
bpo-44133: Skip PyThread_get_thread_native_id() if not available
fac46a7 
test_capi.test_export_symbols() doesn't check if Python exports the
"PyThread_get_thread_native_id" symbol if the _thread.get_native_id()
function is not available (if the PY_HAVE_THREAD_NATIVE_ID macro is
not defined).
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 17, 2022
kulikjak
kulikjak approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@kulikjak kulikjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested the changes and test_capi is happy again.

@vstinner vstinner merged commit 16901c0 into python:main Jan 17, 2022
@vstinner vstinner deleted the test_export branch January 17, 2022 13:49
@vstinner
Copy link
Member Author

vstinner commented Jan 17, 2022

Thanks! I tested the changes and test_capi is happy again.

Thanks for testing my PR on Solaris.

To test my PR, I hacked Python to not define PY_HAVE_THREAD_NATIVE_ID on Linux: test fails without my PR, test pass with my PR.

@vstinner vstinner mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kulikjak kulikjak kulikjak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @kulikjak @the-knights-who-say-ni @bedevere-bot