Skip to content

bpo-31354: Fixing a bug related to LTO only build #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 2 commits into from
Sep 8, 2017
Merged

bpo-31354: Fixing a bug related to LTO only build #3110

gpshead merged 2 commits into from
Sep 8, 2017

Conversation

@octaviansoldea
Copy link

@octaviansoldea octaviansoldea commented Aug 16, 2017 •
edited by bedevere-bot
Loading

Dear Reviewers,

Following several previous communications, this pull request enables compilation of cpython with lto only optimization. While configure’s flag --with-lto is to be used, a new make target has been added: make build_all_lto .

I am looking forward to receive feedback from you.

Best regards,
Octavian

https://bugs.python.org/issue31354

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Aug 16, 2017

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@gpshead gpshead self-requested a review August 16, 2017 19:04
@gpshead gpshead self-assigned this Aug 16, 2017
@octaviansoldea
Copy link
Author

octaviansoldea commented Aug 17, 2017

There is an update I am working for adding lto only compilation option. Please let me add this modification before spending any additional time in reviewing the previous commit.

bpo-31354: Fixing a bug related to LTO only build
84e1532 
Enabling separate lto only compilation mode helps the trade-off
capabilities between required compilation time and optimization
results. Moreover, it enables studies of performance on different
platforms.

Signed-off-by: Octavian Soldea <[email protected]>
@octaviansoldea octaviansoldea changed the title Enabling - lto only - optimization compilation mode bpo-31354: Fixing a bug related to LTO only build Sep 5, 2017
vstinner
vstinner approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would like to see a review by another core dev :-)

@vstinner
Copy link
Member

vstinner commented Sep 5, 2017

Can you please add a NEWS entry using "blurb add"?
https://devguide.python.org/committing/#what-s-new-and-news-entries

@gpshead gpshead merged commit 4c81401 into python:master Sep 8, 2017
@stratakis stratakis mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@vstinner vstinner vstinner approved these changes

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@octaviansoldea @the-knights-who-say-ni @vstinner @gpshead @bitdancer @Mariatta @bedevere-bot